pull down to refresh

5 sats \ 4 replies \ @sox 26 Mar \ parent \ on: Measuring Poverty Correctly Reveals a Hard Truth About the Welfare State econ

On Brave, in `compose` mode, everything seems fine. Our markdown conversion pipeline shouldn't differ between browsers, but on Safari this bug doesn't happen.

I'll keep investigating.

write
compose
128 sats \ 3 replies \ @sox 26 Mar

Okay I think I got what's happening here, the clue is:

but if I swap the '.' for ',' the error doesn’t happen anymore.

We check for misleading links, stuff like [google.com](bing.com) and we replace the 'misleading' link with [bing.com](bing.com). You know, to keep it fair.

But the way we check for misleading links seems to differ between browsers. For Safari, https://11.1 percent is of course not a domain and not even a URL; for Chromium https://11.1 percent is instead a perfectly valid URL and will trigger the misleading link replacement.

We need to make the check more clever.

reply
5 sats \ 1 reply \ @0xbitcoiner OP 26 Mar

Great!

Solution: make your own function to check for valid links! ~lol

reply
5 sats \ 0 replies \ @sox 26 Mar

lmao the problem is that it's our own function that's doing this, we rely on browser's URL detection to do our checks but maybe we shouldn't rely on it that much.

reply
5 sats \ 0 replies \ @sox 26 Mar
reply