pull down to refresh

114 sats \ 2 replies \ @Murch 15h \ parent \ on: This Week in Bitcoin: Bringing the “NOW” to the Orange Dev Suite bitcoin

Looking around on the website a bit, I noticed that the list of maintainers seems to have some quirks. Here are a few things I noticed:

  • Luke Dashjr, Cory Fields, and Carl Dong were never Bitcoin Core maintainers.
  • Sebastian Kung only became a maintainer this year
  • Ava Chow has been a maintainer since 2021
  • Marco Falke was a maintainer from 2016–2023, not 2015–present
  • AFAIK, Jonas Schnelli started in 2015, not 2013
  • Gavin Andresen was maintainer until 2016, not 2015

This list should be accurate and also has sources for most dates: https://bitcoin.stackexchange.com/a/88649/5406

write
compose
22 sats \ 1 reply \ @sorukumar OP 13h

here are the details:

I cross-referenced the StackExchange link you mentioned. Our dataset[https://github.com/sorukumar/orange-dev-data/blob/main/metadata/maintainers.json] actually matches the StackExchange details perfectly, but I had supplemented it with commit data directly from the repository, which caused some quirks in the UI.

  1. On the dates for Gavin and Jonas: The data pipeline was dynamically inferring their timelines based on their earliest and latest merge commit dates rather than their official appointment dates. In Gavin's case, his last actual merge action was in 2015 (even though he held keys until 2016). For Jonas, he had made a local merge commit on a PR branch back in 2013, which tricked the script into expanding his timeline. I've updated the logic to strictly use their official appointment dates, so the chart is now historically accurate.
  2. On Luke Dashjr: He does have about 9 merge commits in our data from the 2011-2016 era. I assume this was before the modern trusted-keys protocol for merge commits was strictly enforced.
  3. On Strategic Maintainers: In the UI, I use dotted/hollow bars for Cory Fields, Carl Dong, and Sebastian Kung (sedited) from 2019–2025. This visually distinguishes that they were Strategic Maintainers (e.g., maintaining the build system, security, or Guix) but did not hold keys to merge into the master branch.

Refining the UI for this chart is still a pending item. I'm planning to move it from the Tracker ("what") over to the Network dashboard ("who") for a cleaner separation of concerns in next iteration.

By the way, what do you think about the approach of visually distinguishing and showing Strategic Maintainers alongside the traditional Committers?

reply
95 sats \ 0 replies \ @Murch 9h

Regarding Luke’s merge commits, it looks like the same thing happened there that also happened to Jonas. I tracked down there of his merge commits. One was the last commit in the PR https://github.com/bitcoin/bitcoin/pull/7192, another was the second in https://github.com/bitcoin/bitcoin/pull/7192, the third was the fourth in https://github.com/bitcoin/bitcoin/pull/505. The first two PRs later got merged by Mara van der Laan, the third by Gavin Andresen.

On Strategic Maintainers: In the UI, I use dotted/hollow bars for Cory Fields, Carl Dong, and Sebastian Kung (sedited) from 2019–2025. This visually distinguishes that they were Strategic Maintainers (e.g., maintaining the build system, security, or Guix) but did not hold keys to merge into the master branch.

At least among Bitcoin Core contributors the term maintainer has a very specific meaning. I’m aware that these three led big projects, but I haven’t heard the term maintainer in that context before. Maybe a different term such as "project lead" would fit better?

reply